os/bluestore: GC infra refactor, more UTs and GC range calculation fixes #11482

Merged
merged 3 commits into from Oct 14, 2016

Projects

None yet

2 participants

@ifed01
Contributor
ifed01 commented Oct 13, 2016

Signed-off-by: Igor Fedotov ifedotov@mirantis.com

@liewegas liewegas added the bluestore label Oct 13, 2016
@liewegas

Fix looks good!

src/os/bluestore/BlueStore.h
@@ -735,6 +735,18 @@ class BlueStore : public ObjectStore,
};
typedef boost::intrusive_ptr<Onode> OnodeRef;
+ //Made a specific class to be able to verify GC logics in Unit Tests
+ struct GarbageCollector {
@liewegas
liewegas Oct 13, 2016 Member

I think it's simpler to just make this a method of ExtentMap, which already includes several unit tests in test_bluestore_types.cc

@ifed01
ifed01 Oct 14, 2016 Contributor

Yeah, that's better...

ifed01 added some commits Oct 12, 2016
@ifed01 ifed01 os/bluestore: isolate GC stuff to be able to cover it with UT
Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>
389d3eb
@ifed01 ifed01 os/bluestore: fix GC gc_end_offset miscalculation
Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>
21b3958
@ifed01 ifed01 os/blustore: fix compile warning
Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>
47c44a2
@ifed01
Contributor
ifed01 commented Oct 14, 2016

@liewegas - fixed

@ifed01 ifed01 added the bug fix label Oct 14, 2016
@liewegas liewegas merged commit 166d154 into ceph:master Oct 14, 2016

1 of 2 checks passed

default Build finished.
Details
Signed-off-by all commits in this PR are signed
Details
@ifed01 ifed01 deleted the ifed01:wip-bluestore-gc-fixes2 branch Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment