os/bluestore: a few cleanups #11483

Merged
merged 2 commits into from Oct 14, 2016

Projects

None yet

2 participants

@liewegas
Member

No description provided.

@liewegas liewegas os/bluestore: simplify blob print if !compressed
Signed-off-by: Sage Weil <sage@redhat.com>
678be45
@xiexingguo
Contributor

I think you shall withdraw the changes related to StupidAllocator in e91b16c.

Seems the original design is that a pre-initialized(and allocated) extentsarray(for efficiency) is allowed to passed in and used to initialize a ExtentListlater. So we can not assert(extents->empty());.

See https://github.com/ceph/ceph/blob/master/src/os/bluestore/BlueFS.cc#L1720
and https://github.com/ceph/ceph/blob/master/src/test/objectstore/Allocator_test.cc#L70
and https://github.com/ceph/ceph/blob/master/src/os/bluestore/BlueStore.cc#L7540
and so on...

Or introduce more changes to fix above all..

@liewegas
Member

yeah, i'll drop that one for now. i don't really like the AllocExtent stuff but it's not pressing.

Eventually I think we want to add a bdev field to bluestore_pextent_t, just like the bluefs_extent_t,s o that we can support multiple devices. A bunch of other stuff needs to be adjusted to handle multiple bdev lba spaces, though (like ref_map_t and a bunch of stuff in fsck()).

@liewegas liewegas os/bluestore: fix warning
Signed-off-by: Sage Weil <sage@redhat.com>
e6d024e
@xiexingguo
Contributor

Reviewed-by:

@liewegas liewegas merged commit 07d1943 into ceph:master Oct 14, 2016

2 checks passed

Signed-off-by all commits in this PR are signed
Details
default Build finished.
Details
@liewegas liewegas deleted the liewegas:wip-bluestore-cleanups branch Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment