os/bluestore: use iterator for erase() method directly #11490

Merged
merged 1 commit into from Oct 14, 2016

Projects

None yet

3 participants

@xiexingguo
Contributor

No description provided.

@liewegas liewegas was assigned by xiexingguo Oct 14, 2016
@ifed01
Contributor
ifed01 commented Oct 14, 2016

Looks like there is duplicate write_onode call for _do_truncate and _do_clone_range too.

@ifed01
Contributor
ifed01 commented Oct 14, 2016

I'm not completely sure if this duplication's worth fixing but I'd prefer to have ALL write_onode calls at the same level for the sake of uniformity, i.e. either at entry points (_zero, _truncate, _clone, etc) or at some underlying ones (_do_zero, _do_truncate, _do_clone_range, etc). Just IMHO though...

@xiexingguo @xiexingguo xiexingguo os/bluestore: use iterator for erase() method directly
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
7a16de7
@xiexingguo xiexingguo changed the title from os/bluestore: a few more cleanups to os/bluestore: use iterator for erase() method directly Oct 14, 2016
@xiexingguo
Contributor

@ifed01 I am with you.

Dropped that change.

@ifed01 ifed01 merged commit d04eee8 into ceph:master Oct 14, 2016

1 of 2 checks passed

default Build started sha1 is merged.
Details
Signed-off-by all commits in this PR are signed
Details
@liewegas
Member

@ifed01 @xiaoxichen agreed on being consistent. Probably do*.... in a handful of cases that will include a duplicate insert, but it's probably safer? No strong preference though.

@xiexingguo xiexingguo deleted the xiexingguo:xxg-wip-bluestore-1014 branch Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment