jewel: build/ops: aarch64: Compiler-based detection of crc32 extended CPU type is broken #11492

Merged
merged 1 commit into from Oct 20, 2016

Projects

None yet

4 participants

@agraf @smithfarm agraf AArch64: Detect crc32 extension support from assembler
The used compiler may or may not be recent enough to recognize the
crc32 extended cpu type. However, it does not really have to know about
them either, since all we do is pass inline assembly instructions to
the assembler.

This patch moves the crc cpu extension detection from compiler based
to assembler based, so that we can build optimized code even when the
compiler does not know about the cpu type yet.

Signed-off-by: Alexander Graf <agraf@suse.de>

(manual backport of e70ab48 - manual backport
was undertaken because jewel uses autotools)
91bd342
@smithfarm smithfarm self-assigned this Oct 14, 2016
@smithfarm smithfarm added this to the jewel milestone Oct 14, 2016
@smithfarm
Contributor

@agraf: Please review.

@smithfarm smithfarm added build/ops and removed core labels Oct 14, 2016
@agraf
agraf approved these changes Oct 14, 2016 View changes
@dachary
Member
dachary commented Oct 20, 2016

@tchaikov does this backport look good to merge ? It passed the rados (http://tracker.ceph.com/issues/17487#note-19) suite except for two jobs that are, I believe unrelated. It also passed the upgrade/jewel-x and upgrade/hammer-x (http://tracker.ceph.com/issues/17487#note-22) suites.

@tchaikov tchaikov was assigned by dachary Oct 20, 2016
@tchaikov
Contributor

@dachary it's good to merge.

@dachary dachary merged commit 62f7f64 into ceph:jewel Oct 20, 2016

2 checks passed

Signed-off-by all commits in this PR are signed
Details
default Build finished.
Details
@smithfarm smithfarm deleted the SUSE:wip-17575-jewel branch Oct 20, 2016
@theanalyst theanalyst changed the title from jewel: aarch64: Compiler-based detection of crc32 extended CPU type is broken to "jewel: build/ops: aarch64: Compiler-based detection of crc32 extended CPU type is broken" Nov 17, 2016
@theanalyst theanalyst changed the title from "jewel: build/ops: aarch64: Compiler-based detection of crc32 extended CPU type is broken" to jewel: build/ops: aarch64: Compiler-based detection of crc32 extended CPU type is broken Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment