systemd: add ceph-fuse service file #11542

Merged
merged 1 commit into from Dec 14, 2016

Projects

None yet

2 participants

@batrick
Contributor
batrick commented Oct 19, 2016

Signed-off-by: Patrick Donnelly pdonnell@redhat.com

@jcsp
Contributor
jcsp commented Oct 19, 2016

Hmm. What's the use case for this vs. having something in fstab?

@batrick
Contributor
batrick commented Oct 21, 2016

I'm not really sure if fstab is a better way to do this. My
understanding is that mount units are considered the way forward and
they do provide more configuration options.

We might want to change this ceph-fuse@.service unit to a .mount
unit but the naming requirements are unfortunately strict (the mount
unit name must match the mount point name... but we don't know
where users will want to mount ceph-fuse).

@batrick
Contributor
batrick commented Oct 23, 2016

I had to make small modification to the unit as the namespace modification directives like "PrivateDevices" cause the mounted file system to be unavailable to the rest of the system. That's fixed now and I've tested the unit file with my Linode tests without any issues.

@jcsp
Contributor
jcsp commented Nov 15, 2016

So I was googling about this topic and saw:

Mount units may either be configured via unit files, or via /etc/fstab (see fstab(5) for details). Mounts listed in /etc/fstab will be converted into native units dynamically at boot and when the configuration of the system manager is reloaded. In general, configuring mount points through /etc/fstab is the preferred approach. See systemd-fstab-generator(8) for details about the conversion.
(https://www.freedesktop.org/software/systemd/man/systemd.mount.html)

However I can see the utility of having the ceph-fuse service file as it lets us provide the "network-online.target local-fs.target time-sync.target" requirements to avoid users having weird issues when they forget "netdev" etc.

I guess I have no problem merging this, can you add something to the docs in this PR to explain how to use it (could just add to fstab.rst)? I'm guessing one is supposed to create a systemd unit with the mount point in the name?

@batrick batrick was assigned by jcsp Nov 15, 2016
@jcsp
Contributor
jcsp commented Nov 29, 2016

@batrick this is good from my POV once it has docs

@batrick
Contributor
batrick commented Nov 29, 2016

Sorry this fell off my radar. I'll finish this up soon.

@batrick batrick systemd: add ceph-fuse service file
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
d32d70b
@batrick
Contributor
batrick commented Dec 2, 2016

@jcsp, I've added the docs and did some testing to make sure it works properly via ceph-ansible. I think this is ready to go.

@batrick batrick assigned jcsp and unassigned batrick Dec 6, 2016
@jcsp
Contributor
jcsp commented Dec 7, 2016

(I'm waiting until Kraken branches to merge this to master)

@jcsp
jcsp approved these changes Dec 14, 2016 View changes
@jcsp jcsp merged commit 63ae857 into ceph:master Dec 14, 2016

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment