os/bluestore: fsck: fix omap_head check #11726

Merged
merged 1 commit into from Nov 2, 2016

Projects

None yet

3 participants

@liewegas
Member
liewegas commented Nov 1, 2016

Signed-off-by: Sage Weil sage@redhat.com

@ifed01 ifed01 was assigned by liewegas Nov 1, 2016
src/os/bluestore/BlueStore.cc
if (used_omap_head.count(o->onode.omap_head)) {
derr << __func__ << " " << oid << " omap_head " << o->onode.omap_head
<< " already in use" << dendl;
++errors;
- break;
}
@xiexingguo
xiexingguo Nov 2, 2016 Contributor

Nit, we might want to put an extra else here...

else {
  used_omap_head.insert(o->onode.omap_head);  
}
@xiexingguo
Contributor

Reviewed-by:

@ifed01
Contributor
ifed01 commented Nov 2, 2016

LGTM except the nit pointed out by @xiexingguo

@liewegas liewegas os/bluestore: fsck: fix omap_head check
Signed-off-by: Sage Weil <sage@redhat.com>
886d201
@liewegas liewegas merged commit d033f15 into ceph:master Nov 2, 2016

0 of 2 checks passed

Signed-off-by checking if commits are signed
Details
default Build triggered. sha1 is merged.
Details
@liewegas liewegas deleted the liewegas:wip-bluestore-fsck-omap branch Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment