os/bluestore: speed up omap-key generation for same onode #11807

Merged
merged 1 commit into from Nov 8, 2016

Projects

None yet

2 participants

@xiexingguo
Contributor

This is useful if we have to batch-process omap kvs.

Signed-off-by: xie xingguo xie.xingguo@zte.com.cn

@xiexingguo xiexingguo added the bluestore label Nov 7, 2016
@liewegas liewegas was assigned by xiexingguo Nov 7, 2016
@liewegas
Member
liewegas commented Nov 7, 2016

We can probably do even better by reusing the same string (at prefix scope) and truncating it to 8+1 each pass through the loop. That avoids the memory copy and (likely) an allocation.

@xiexingguo xiexingguo os/bluestore: speed up omap-key generation for same onode
This is useful if we have to batch-process omap kvs.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
db769dc
@xiexingguo
Contributor

@liewegas Fixed.

@liewegas liewegas merged commit 4bc6bad into ceph:master Nov 8, 2016

1 of 2 checks passed

default Build finished.
Details
Signed-off-by all commits in this PR are signed
Details
@xiexingguo xiexingguo deleted the xiexingguo:xxg-wip-bs-1107 branch Nov 8, 2016
@xiexingguo xiexingguo added a commit to xiexingguo/ceph that referenced this pull request Nov 10, 2016
@xiexingguo xiexingguo os/bluestore: speed up omap-key generation for same onode(the read pa…
…ths)

In ceph#11807 we only modify the write paths,
this patch fixes the read parts too, which are more time-sensitive.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
d04f7d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment