os/bluestore: reap ioc when stopping aio_thread. #11811

Merged
merged 1 commit into from Nov 9, 2016

Projects

None yet

2 participants

@tanghaodong25
Contributor

there is possibillity that reap_ioc don't excute when stopping
aio_thread. so add reap_ioc after aio_thread is stopped.

Signed-off-by: Haodong Tang haodong.tang@intel.com

@liewegas liewegas added the bluestore label Nov 7, 2016
@liewegas
Member
liewegas commented Nov 7, 2016

Did you hit this memory leak in practice? I would be inclined to put reap_ioc() at teh end of _aio_thread() outside of the loop, but either there or where you put it it doesn't help if you set aio_loop while aios are still in flight... which is I think the only case where the leak would happen. To address that, you need to flush before shutting down...

@tanghaodong25 tanghaodong25 os/bluestore: reap ioc when stopping aio_thread.
there is possibillity that reap_ioc don't excute when stopping
aio_thread. so add reap_ioc after aio_thread is stopped.

Signed-off-by: Haodong Tang <haodong.tang@intel.com>
d13b2b3
@tanghaodong25
Contributor

@liewegas I'm not sure I understand you correctly, Why are there aios in flight when calling aio_stop? aio finished before ioc is pushed to ioc_reap_queue.

@liewegas

I udnerstand now. Looks good!

@liewegas liewegas merged commit ee3fa76 into ceph:master Nov 9, 2016

1 of 2 checks passed

default Build finished.
Details
Signed-off-by all commits in this PR are signed
Details
@tanghaodong25 tanghaodong25 deleted the tanghaodong25:reap-ioc-wip branch Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment