os/bluestore: some more cleanups #11910

Merged
merged 2 commits into from Nov 11, 2016

Projects

None yet

3 participants

@xiexingguo
Contributor

No description provided.

xiexingguo added some commits Nov 11, 2016
@xiexingguo xiexingguo os/bluestore: make Extent deleter as independent disposer
Duplicated definition of lambas of same function is not good.
Also switching ExtentMap::rm() to use the new disposer to
keep pace with others.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
b32cbcd
@xiexingguo xiexingguo os/bluestore: remove dead assert
This assert will never fire, hence it can be safely removed.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
5bfe679
@liewegas liewegas was assigned by xiexingguo Nov 11, 2016
src/os/bluestore/BlueStore.cc
- assert(buffer_bytes >= b->length);
- buffer_bytes -= b->length;
- assert(buffer_list_bytes[BUFFER_WARM_IN] >= b->length);
- buffer_list_bytes[BUFFER_WARM_IN] -= b->length;
@ifed01
ifed01 Nov 11, 2016 Contributor

adjust_buffer_size uses b->cache_private for this line hence the replacement is not equivalent here IMHO.

@xiexingguo
xiexingguo Nov 11, 2016 Contributor

We are evicting buffers from the warm_in list here, so the cache_private will be deemed to be BUFFER_WARM_IN.
Thus the replacement is still equivalent, right?

@liewegas
liewegas Nov 11, 2016 Member

Looks like a safe change. It's just trading performance for maintainability. I'm ambivalent..

@xiexingguo
xiexingguo Nov 11, 2016 Contributor

my fault:(, drop this for now

@xiexingguo
Contributor

retest this please

@ifed01
ifed01 approved these changes Nov 11, 2016 View changes

LGTM

@xiexingguo
Contributor

Igor, I bet the performance shall win so I drop the last change.
Thanks for the review.

@liewegas liewegas merged commit 26a3dae into ceph:master Nov 11, 2016

1 of 2 checks passed

default Build finished.
Details
Signed-off-by all commits in this PR are signed
Details
@xiexingguo xiexingguo deleted the xiexingguo:xxg-wip-bluestore-1111 branch Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment