os/bluestore: misc. fixes and cleanups #11964

Merged
merged 6 commits into from Nov 15, 2016

Projects

None yet

2 participants

@xiexingguo
Contributor

No description provided.

xiexingguo added some commits Nov 12, 2016
@xiexingguo xiexingguo os/bluestore: use built-in methods for ExtentMap resharding and encoding
Hope this can improve the code readability a little...

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
348ca7f
@xiexingguo xiexingguo os/bluestore: assert from access violation
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2ce6af0
@xiexingguo xiexingguo os/bluestore: static apply() method for bluestore internal-use only
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
865b715
@liewegas liewegas was assigned by xiexingguo Nov 14, 2016
src/os/bluestore/BlueStore.cc
+ } else {
+ derr << __func__ << " " << oid << " has uninitialized nid"
+ << dendl;
+ ++errors;
@liewegas
liewegas Nov 14, 2016 Member

We only set the nid in certain paths... and we only use it for omap. If we do this, we should consolidate all the assign_nid calls to the points where we set exists = true.

@xiexingguo
xiexingguo Nov 15, 2016 Contributor

Ah, that's true:)

@liewegas

Let's drop the nid fsck check for now; rest looks good?

@liewegas liewegas added this to the kraken milestone Nov 14, 2016
xiexingguo added some commits Nov 14, 2016
@xiexingguo xiexingguo os/bluestore: make fsck() can catch uninitialized sbid too
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
6b4bee2
@xiexingguo xiexingguo os/bluestore: formatting nits
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
8ae9ecf
@xiexingguo xiexingguo os/bluestore: simplify OmapIteratorImpl::valid()
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
5884850
@liewegas liewegas merged commit 503cb53 into ceph:master Nov 15, 2016

1 of 2 checks passed

default Build finished.
Details
Signed-off-by all commits in this PR are signed
Details
@xiexingguo xiexingguo deleted the xiexingguo:xxg-wip-bluestore-1112 branch Nov 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment