os/bluestore: avoid unnecessary call to init_csum() #12015

Merged
merged 2 commits into from Nov 17, 2016

Projects

None yet

4 participants

@xiexingguo
Contributor

We have to initiate CSumType from 1, which represents CSUM_NONE,
to be aligned with OSDMnitor's pool_opts_t handling.

So we have to explicitly check against CSUM_NONE to skip init_csum(),
which will set FLAG_CSUM and alloc memory for csum_data and thus
shall be avoided whenever it is possible.

Signed-off-by: xie xingguo xie.xingguo@zte.com.cn

xiexingguo added some commits Nov 16, 2016
@xiexingguo xiexingguo os/bluestore: avoid unnecessary call to init_csum()
We have to initiate CSumType from 1, which represents CSUM_NONE,
to be aligned with OSDMnitor's pool_opts_t handling.

So we have to explicitly check against CSUM_NONE to skip init_csum(),
which will set FLAG_CSUM and alloc memory for csum_data and thus
shall be avoided whenever it is possible.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
5beb99e
@xiexingguo xiexingguo os/bluestore: more readability improvements
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
eedb3f4
@dachary
Member
dachary commented Nov 16, 2016

jenkins test this please (eio/scrub failure)

@xiexingguo
Contributor

retest this please

@liewegas liewegas was assigned by xiexingguo Nov 16, 2016
@liewegas
Member

retest this please

@xiexingguo
Contributor

retest this please

@ifed01 ifed01 merged commit 7814549 into ceph:master Nov 17, 2016

2 checks passed

Signed-off-by all commits in this PR are signed
Details
default Build finished.
Details
@xiexingguo xiexingguo deleted the xiexingguo:xxg-wip-bluestore-init-csum branch Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment