os/bluestore: fix latency calculation #12040

Merged
merged 2 commits into from Nov 18, 2016

Projects

None yet

3 participants

@liupan1111
Contributor

add two statistic variables in bluestore to cal commit latency and apply latency.

Signed-off-by: Pan Liu pan.liu@istuary.com

@liupan1111
Contributor

@liewegas, @tchaikov , please help take a look. Thanks.

@tchaikov
Contributor

@liupan1111 could you remove the merge commit from your PR?

@liupan1111
Contributor

@tchaikov, please give me some guidence. I could use git push -f to avoid the merge commit as the last commit.But if it happens as the first commit because I merge newest from ceph/master to my forked, I cannot find a way to remove it...

@tchaikov
Contributor

@liupan1111 how about cherry-picking e0afcfd and 37822cd in a brand new branch sync'ed with ceph/master, then "git push -f"?

- f->open_object_section("fs_perf_stat");
- fs_perf_stat.dump(f);
+ f->open_object_section("perf_stat");
+ os_perf_stat.dump(f);
@liewegas
liewegas Nov 17, 2016 Member

Please put a note in PendingReleaseNotes that the json schema has changed.

@liupan1111
liupan1111 Nov 18, 2016 Contributor

Sure.

src/os/bluestore/BlueStore.cc
+ b.add_time_avg(l_bluestore_ack_lat, "ack_lat",
+ "Average ack latency");
+ b.add_time_avg(l_bluestore_commit_lat, "commit_lat",
+ "Average commit latency");
@liewegas
liewegas Nov 17, 2016 Member

No need for 2 of these; ack and commit callbacks are triggered at the same time for bluestore

@liewegas
liewegas Nov 17, 2016 Member

Let's just do commit_lat

@liupan1111
liupan1111 Nov 18, 2016 Contributor

agree.

@liewegas liewegas added the bluestore label Nov 17, 2016
@tchaikov tchaikov removed the core label Nov 17, 2016
liupan1111 added some commits Nov 18, 2016
@liupan1111 liupan1111 OSD: change the prefix from fs_* to os_*, because commit_latency and
apply_latency will be used not only for filestore.

Signed-off-by: Pan Liu <pan.liu@istuary.com>
3ea4760
@liupan1111 liupan1111 os/bluestore: fix a bug: when using bluestore, the output of
"ceph osd perf" is always 0ms.

Signed-off-by: Pan Liu <pan.liu@istuary.com>
c7f55c4
@liupan1111
Contributor

@liewegas @tchaikov , I've modified as your suggestion, please help review. Thanks.

@liewegas liewegas changed the title from os/bluestore: fix a bug: when using bluestore, the output of "ceph osd perf" is always 0ms. to os/bluestore: fix latency calculation Nov 18, 2016
@liewegas liewegas merged commit b02d004 into ceph:master Nov 18, 2016

2 checks passed

Signed-off-by all commits in this PR are signed
Details
default Build finished.
Details
@liupan1111 liupan1111 deleted the liupan1111:wip-bluestore-lat-report branch Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment