os/bluestore: kill dead gc-related counters #12065

merged 4 commits into from Nov 21, 2016


None yet

5 participants


As the gc logic is deprecated by #12042

Signed-off-by: xie xingguo xie.xingguo@zte.com.cn

@xiexingguo xiexingguo os/bluestore: kill dead gc-related counters
As the gc logic is deprecated by ceph#12042

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@xiexingguo xiexingguo os/bluestore: rename Extent::end() to Extent::logical_end()
and use the new method to simplify code.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@tchaikov tchaikov added the cleanup label Nov 18, 2016
dachary commented Nov 18, 2016

jenkins test this please (asok)

@xiexingguo xiexingguo os/bluestore: add counter to trace extents have been removed due to c…

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@liewegas liewegas was assigned by xiexingguo Nov 18, 2016
@liewegas liewegas added this to the kraken milestone Nov 18, 2016
@@ -1280,9 +1280,8 @@ ostream& operator<<(ostream& out, const BlueStore::SharedBlob& sb)
return out << ")";
-BlueStore::SharedBlob::SharedBlob(uint64_t i, const string& k, Cache *c)
ifed01 Nov 18, 2016 Contributor

I'd prefer a more robust change that introduce a ctor without sbid/key assignment and sbid setter that assigns both sbid and key(the latter to be calculated internally). Additional ctor that assigns sbid/key via the introduced setter is OK too. General idea here is to have an SharedBlob interface that ensures consistent internal state, i.e. sbid and key are assigned all together.

liewegas Nov 18, 2016 Member

That would be a bit nicer, yeah.. It's just the open_shared_blob() caller that should use a new ctor, and the new ctor should do the get_shared_blob_key() call

xiexingguo Nov 19, 2016 Contributor


@xiexingguo xiexingguo os/bluestore: refactor ctor of SharedBlob
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@ifed01 ifed01 merged commit 71b1a41 into ceph:master Nov 21, 2016

2 checks passed

Signed-off-by all commits in this PR are signed
default Build finished.
@xiexingguo xiexingguo deleted the xiexingguo:xxg-wip-kill-gc-counters branch Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment