New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: fix slave zonegroup cannot enable the bucket versioning #12175

Merged
merged 1 commit into from Apr 6, 2017

Conversation

Projects
None yet
3 participants
@dongbula

dongbula commented Nov 24, 2016

fix http://tracker.ceph.com/issues/18003

The slave zonegroup can't enable bucket(local) versioning, this fix the bug.

@dongbula dongbula changed the title from rgw:fix slave zonegroup cannot enable the bucket versioning to rgw: fix slave zonegroup cannot enable the bucket versioning Nov 25, 2016

lvshuhua
rgw: fix slave zonegroup cannot enable the bucket versioning
Signed-off-by: lvshuhua <lvshuhua@cmss.chinamobile.com>
@oritwas

This comment has been minimized.

Contributor

oritwas commented Dec 12, 2016

this will not forward the request to the meta master.
see: #12444

@oritwas oritwas changed the title from rgw: fix slave zonegroup cannot enable the bucket versioning to DNM: rgw: fix slave zonegroup cannot enable the bucket versioning Dec 12, 2016

@dongbula

This comment has been minimized.

dongbula commented Mar 16, 2017

@cbodley hi, please help review this pr, thanks:)

@cbodley

This comment has been minimized.

Contributor

cbodley commented Mar 16, 2017

hi @dongbula, so far we've only been testing with a single zonegroup in test_multi.py, so it's hard for me to validate this one. would you be willing to add a --num-zonegroups option to test_multi.py, along with a test case for this pr?

@cbodley cbodley self-assigned this Mar 16, 2017

@dongbula

This comment has been minimized.

dongbula commented Mar 20, 2017

@cbodley okey, i will add that latter :)

@dongbula

This comment has been minimized.

dongbula commented Apr 1, 2017

@cbodley hi, you can run test_bucket_versioning in test_multi.py to validate this pr under multi-zonegroup environment now, see the new test_multi.py at #14216
thanks!

@cbodley cbodley changed the title from DNM: rgw: fix slave zonegroup cannot enable the bucket versioning to rgw: fix slave zonegroup cannot enable the bucket versioning Apr 4, 2017

@cbodley

This comment has been minimized.

Contributor

cbodley commented Apr 4, 2017

this will not forward the request to the meta master. see: #12444

@oritwas the forwarding logic remains unchanged. this addresses an issue where the request has already been forwarded to the master, but we fail with ERR_PERMANENT_REDIRECT instead of processing the request locally. this only happens in configurations with multiple zonegroups

@cbodley

This comment has been minimized.

Contributor

cbodley commented Apr 4, 2017

@dongbula thanks for the updates to test_multi.py! that made it easy to reproduce the failures against master (which exposed some other issues with redirect handling, see #14319). and i see that test_bucket_versioning() now passes with this fix 👍

next step is to run through teuthology

@oritwas

This comment has been minimized.

Contributor

oritwas commented Apr 5, 2017

lgtm

@cbodley

This comment has been minimized.

@cbodley

cbodley approved these changes Apr 6, 2017

@cbodley cbodley merged commit d346b1b into ceph:master Apr 6, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment