os/bluestore: clean up Allocator::dump #12282

Merged
merged 3 commits into from Dec 3, 2016

Projects

None yet

2 participants

@liewegas
Member
liewegas commented Dec 2, 2016

No description provided.

liewegas added some commits Dec 2, 2016
@liewegas liewegas os/bluestore: drop unused ostream arg to Allocator::dump
Signed-off-by: Sage Weil <sage@redhat.com>
9911f9f
@liewegas liewegas os/bluestore: dump allocator state at lowest debug level
Signed-off-by: Sage Weil <sage@redhat.com>
3121892
@liewegas liewegas added the bluestore label Dec 2, 2016
@liewegas liewegas added this to the kraken milestone Dec 2, 2016
@varadakari
Contributor

@liewegas need to add dump() to the failing allocation asserts.

@varadakari
Contributor

rest looks good

@liewegas liewegas os/bluestore: dump allocator state on allocation failure
This is probably noisy for an *actual* ENOSPC, but the OSD should
actually prevent those from happening in general, and we are
very interested in fixing spurious allocation failures due to
allocator problems.  See http://tracker.ceph.com/issues/18054

Signed-off-by: Sage Weil <sage@redhat.com>
462110a
@liewegas
Member
liewegas commented Dec 2, 2016

@varadakari look ok?

@varadakari

Looks good

@varadakari varadakari merged commit 177bae7 into ceph:master Dec 3, 2016

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment