New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: add RGW and MDS to libcephd #12345

Merged
merged 3 commits into from Jan 16, 2017

Conversation

Projects
None yet
4 participants
@bassam
Member

bassam commented Dec 6, 2016

This PR adds RGW and MDS to embedded Ceph. The approach is similar to the work to add MON and OSD keeping the changes to a minimum. Also in here is a commit to make the FCGI dependency optional

@liewegas liewegas added the build/ops label Dec 6, 2016

@tchaikov tchaikov added the feature label Dec 7, 2016

@@ -110,7 +110,9 @@ static void signal_fd_finalize()
static void handle_sigterm(int signum)
{
dout(1) << __func__ << dendl;
#if defined(WITH_RADOSGW_ASIO_FRONTEND)

This comment has been minimized.

@cbodley

cbodley Dec 21, 2016

Contributor

ASIO -> FCGI

@@ -316,7 +322,9 @@ int main(int argc, const char **argv)
curl_global_init(CURL_GLOBAL_ALL);
#if defined(WITH_RADOSGW_ASIO_FRONTEND)

This comment has been minimized.

@cbodley

cbodley Dec 21, 2016

Contributor

ASIO -> FCGI

@bassam

This comment has been minimized.

Member

bassam commented Dec 21, 2016

@cbodley fixed in rebased bb0298f

bassam added some commits Nov 18, 2016

embedded: add MDS to libcephd
Added MDS to libcephd

Signed-off-by: Bassam Tabbara <bassam.tabbara@quantum.com>
embedded: add RGW to libcephd
added RGW and rgw-admin to libcephd.

Signed-off-by: Bassam Tabbara <bassam.tabbara@quantum.com>
rgw: make fcgi optional during build
fcgi can now be compiled out of the binary. this reduces the system
dependencies when fcgi is not needed or used.

Signed-off-by: Bassam Tabbara <bassam.tabbara@quantum.com>
@bassam

This comment has been minimized.

Member

bassam commented Jan 11, 2017

@cbodley @tchaikov can you please take a look. I just rebased and fixed conflicts. Would be great if we can put this in master before more conflicts arise :-)

@tchaikov tchaikov self-assigned this Jan 12, 2017

@tchaikov

lgtm @cbodley what do you think?

@cbodley

This comment has been minimized.

Contributor

cbodley commented Jan 12, 2017

the code looks good. does it actually run and pass tests?

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jan 12, 2017

@bassam @cbodley i will pull this into my test branch to see if it builds on shaman and passes rados qa tests.

@tchaikov tchaikov added the needs-qa label Jan 12, 2017

@cbodley

This comment has been minimized.

Contributor

cbodley commented Jan 12, 2017

what i meant was, do we have any test plans for the embedded versions? for example, can it successfully bring up two functional daemons if you cephd_run_*() them from separate threads? i'm guessing that we'll run into a lot of problems with g_ceph_context and other global state, and someone will need to do that testing and work through the issues. until that happens, i think it's important to document these constraints in libcephd.h (and possibly enforce them by having the cephd_run_*() functions immediately return an error if another daemon is already running)

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jan 12, 2017

do we have any test plans for the embedded versions?

no, AFAICT. at least, not yet.

@bassam

This comment has been minimized.

Member

bassam commented Jan 12, 2017

@cbodley there are not tests yet. cephd_run_*() does run well when there is a single daemon per process as you observed, but not for multiple daemons per process. The plan is to keep driving this work such that it can be used in true embedded form.

Note also that embedded ceph is not currently included in distro packages. Once the work is complete we would need to do so, add documentation, and integration testing.

I'll add some documentation on the current constraints in a separate PR.

@tchaikov tchaikov changed the title from embedded: add RGW and MDS to cmake: add RGW and MDS to libcephd Jan 16, 2017

@tchaikov tchaikov merged commit 2ea4b94 into ceph:master Jan 16, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@bassam bassam deleted the rook:wip-embedded-add-rgw-mds branch Jan 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment