os/bluestore: don't implicitly create the source object for clone #12353

Merged
merged 1 commit into from Dec 16, 2016

Projects

None yet

2 participants

@xiexingguo
Contributor

We shall implicitly create the destination object instead and
missing source object usually indicates an error.

Signed-off-by: xie xingguo xie.xingguo@zte.com.cn

@xiexingguo xiexingguo os/bluestore: don't implicitly create the source object for clone
We shall implicitly create the destination object instead and
missing source object usually indicates an error.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
69bbff2
@xiexingguo
Contributor

@liewegas One more.

@liewegas liewegas added the bluestore label Dec 7, 2016
@liewegas
Member
liewegas commented Dec 7, 2016

This is how the interface is defined, how FileStore also behaves, and how the Synthetic model in store_test.cc models and tests it. If we change it here we have to change it everywhere else.

Is it a problem the way it is now?

@xiexingguo
Contributor

Is it a problem the way it is now?

Not really. But seems FileStore won't tolerate the missing of source object...

https://github.com/ceph/ceph/blob/master/src/os/filestore/FileStore.cc#L3490

@liewegas
Member
liewegas commented Dec 7, 2016
@liewegas liewegas merged commit 4444540 into ceph:master Dec 16, 2016

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@xiexingguo xiexingguo deleted the xiexingguo:xxg-wip-bluestore-1207-01 branch Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment