New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: explictly call find_package(PythonInterp) first to fix build err #12385

Merged
merged 1 commit into from Jan 3, 2017

Conversation

Projects
None yet
4 participants
@dlan17
Contributor

dlan17 commented Dec 8, 2016

this is an un-modified message from dev-util/cmake-3.7.1
/usr/share/cmake/Modules/FindPythonLibs.cmake

call find_package(PythonInterp) first to
get the currently active Python version by default with a consistent
version of PYTHON_LIBRARIES.

Signed-off-by: Yixun Lan dlan@gentoo.org


the detail error message we've met here

Found PythonInterp: python (found suitable version "2.7.12", minimum required is "2")
CMake Error at /usr/share/cmake/Modules/FindPythonLibs.cmake:54 (get_filename_component):
get_filename_component called with incorrect number of arguments
Call Stack (most recent call first):
src/CMakeLists.txt:209 (find_package)

explictly call find_package(PythonInterp) first to fix build err
this is an un-modified message from dev-util/cmake-3.7.1
/usr/share/cmake/Modules/FindPythonLibs.cmake

call ``find_package(PythonInterp)`` first to
 get the currently active Python version by default with a consistent
version  of PYTHON_LIBRARIES.

Signed-off-by: Yixun Lan <dlan@gentoo.org>

---
the detail error message we've met here

Found PythonInterp: python (found suitable version "2.7.12", minimum required is "2")
CMake Error at /usr/share/cmake/Modules/FindPythonLibs.cmake:54 (get_filename_component):
  get_filename_component called with incorrect number of arguments
Call Stack (most recent call first):
  src/CMakeLists.txt:209 (find_package)
@dlan17

This comment has been minimized.

Contributor

dlan17 commented Dec 8, 2016

please also consider merge to the kraken branch, as I discover this issue at ceph-11.0.2, but create this patch for master branch

@liewegas liewegas requested a review from alimaredia Dec 29, 2016

@liewegas liewegas changed the title from explictly call find_package(PythonInterp) first to fix build err to cmake: explictly call find_package(PythonInterp) first to fix build err Dec 29, 2016

@alimaredia

retest this please

@alimaredia alimaredia merged commit 209c0a6 into ceph:master Jan 3, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment