New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include/fs_types: fix unsigned integer overflow #12440

Merged
merged 1 commit into from Jan 27, 2017

Conversation

Projects
None yet
4 participants
@runsisi
Contributor

runsisi commented Dec 12, 2016

stats image has (stripe_count * object_size) > UINT32_MAX results following exception:

  ...
  5: (()+0xc3391) [0x7f720e638391]
  6: (librbd::Image::stat(rbd_image_info_t&, unsigned long)+0x46) [0x7f720e5d1fd6]
  7: (rbd::action::info::execute(boost::program_options::variables_map const&)+0x194) [0x7f7218266744]
  8: (rbd::Shell::execute(std::vector<char const*, std::allocator<char const*> > const&)+0x87d) [0x7f721823c1bd]
  9: (main()+0x72) [0x7f721820b4c2]
  ...
  Floating point exception (core dumped)

Signed-off-by: runsisi runsisi@zte.com.cn

runsisi
include/fs_types: fix unsigned integer overflow
stats image has (stripe_count * object_size) > UINT32_MAX results following exception:
  ...
  5: (()+0xc3391) [0x7f720e638391]
  6: (librbd::Image::stat(rbd_image_info_t&, unsigned long)+0x46) [0x7f720e5d1fd6]
  7: (rbd::action::info::execute(boost::program_options::variables_map const&)+0x194) [0x7f7218266744]
  8: (rbd::Shell::execute(std::vector<char const*, std::allocator<char const*> > const&)+0x87d) [0x7f721823c1bd]
  9: (main()+0x72) [0x7f721820b4c2]
  ...
  Floating point exception (core dumped)

Signed-off-by: runsisi <runsisi@zte.com.cn>

@liewegas liewegas added this to the kraken milestone Dec 12, 2016

@dillaman dillaman added rbd common and removed common rbd labels Dec 16, 2016

@dillaman

This comment has been minimized.

Contributor

dillaman commented Dec 16, 2016

@runsisi can I ask what your stripe unit / count are currently configured at? I'm just wondering the utility of such a large stripe period (not discounting that this is a bug).

@liewegas liewegas removed this from the kraken milestone Dec 16, 2016

@runsisi

This comment has been minimized.

Contributor

runsisi commented Dec 17, 2016

@dillaman it was set by our test engineer by accident
and then we found it could not be removed anymore :(

@liewegas liewegas added the cephfs label Jan 13, 2017

@jcsp jcsp merged commit f3c7ab7 into ceph:master Jan 27, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@runsisi runsisi deleted the runsisi:wip-fix-fp-exception branch Feb 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment