osd/ReplicatedPG::record_write_error: don't leak orig_reply on cancel #12450

Merged
merged 1 commit into from Dec 12, 2016

Projects

None yet

2 participants

@athanatos
Member

The submit_log_entries machinery depends on the destructor for the
functor cleaning up after itself to handle cancelation. I could have
introduced a local intrusive_ptr and captured that instead, but this is
slightly less magic.

Fixes: http://tracker.ceph.com/issues/18180
Signed-off-by: Samuel Just sjust@redhat.com

@athanatos athanatos ReplicatedPG::record_write_error: don't leak orig_reply on cancel
The submit_log_entries machinery depends on the destructor for the
functor cleaning up after itself to handle cancelation.  I could have
introduced a local intrusive_ptr and captured that instead, but this is
slightly less magic.

Fixes: http://tracker.ceph.com/issues/18180
Signed-off-by: Samuel Just <sjust@redhat.com>
fe456b8
@athanatos athanatos added this to the kraken milestone Dec 12, 2016
@liewegas liewegas was assigned by athanatos Dec 12, 2016
@athanatos athanatos requested a review from liewegas Dec 12, 2016
@liewegas liewegas changed the title from ReplicatedPG::record_write_error: don't leak orig_reply on cancel to osd/ReplicatedPG::record_write_error: don't leak orig_reply on cancel Dec 12, 2016
@liewegas liewegas merged commit df052e7 into ceph:master Dec 12, 2016

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment