New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: never send rados ack (only commit) #12451

merged 12 commits into from Dec 29, 2016


None yet
3 participants

liewegas commented Dec 12, 2016

No description provided.


This comment has been minimized.


yuriw commented Dec 14, 2016

@liewegas pls rebase

`[yuriw@smithi020 build]$ git pull wip-osd-on-applied
remote: Counting objects: 20, done.
remote: Total 20 (delta 16), reused 16 (delta 16), pack-reused 3
Unpacking objects: 100% (20/20), done.

  • branch wip-osd-on-applied -> FETCH_HEAD
    Auto-merging src/osd/PrimaryLogPG.h
    CONFLICT (content): Merge conflict in src/osd/PrimaryLogPG.h
    Auto-merging src/osd/
    CONFLICT (content): Merge conflict in src/osd/
    Auto-merging src/osd/OSD.h
    Auto-merging src/osd/
    Automatic merge failed; fix conflicts and then commit the result.

This comment has been minimized.


liewegas commented Dec 20, 2016

@athanatos pushed a bunch of new patches removing replay support


This comment has been minimized.


liewegas commented Dec 28, 2016

retest this please

liewegas added some commits Dec 10, 2016

osd/ReplicatedPG: kill hit_set_flushing
This was added before we started taking the ondisk lock in order to allow
reading a just-written hitset.  Since this is a rare path anyway, just
take the ondisk lock.

Signed-off-by: Sage Weil <>
osd: remove 'rlat' read latency metrics
These are measuring how long of a delay we see before ops are readable.
They are calculated in the on_applied path, which we'd like to remove,
and weren't reliably calculated anyway.

Signed-off-by: Sage Weil <>
osd/ReplicatedPG: do not send ACK separate from COMMIT
This never comes before COMMIT, making it useless to clients.  And it's
just unnecessary overhead.

Signed-off-by: Sage Weil <>
osd: we can discard "replay" ops
Signed-off-by: Sage Weil <>
osd/PG: do not queue ops for replay
We no longer send ACKs, so this can't happen anyway.

Signed-off-by: Sage Weil <>
osd/PG: do not go into replay state
Signed-off-by: Sage Weil <>
osd: remove replay_queue
Signed-off-by: Sage Weil <>
osd: simplify dup/resent logic
No need to special ack path.

Signed-off-by: Sage Weil <>
osd/PG: remove waiting_for_ack
No longer used.

Signed-off-by: Sage Weil <>
doc: remove crash_replay_interval mentions
Signed-off-by: Sage Weil <>
qa/workunits: remove crash_replay_interval tests
Signed-off-by: Sage Weil <>

@liewegas liewegas merged commit bc197d7 into ceph:master Dec 29, 2016

3 checks passed

Signed-off-by all commits in this PR are signed
Unmodifed Submodules submodules for project are unmodified
default Build finished.

@liewegas liewegas deleted the liewegas:wip-osd-on-applied branch Dec 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment