mount: do not print "unknown" option to kclient #12465
Conversation
There was a problem hiding this comment.
Reviewed-by: Greg Farnum gfarnum@redhat.com
Let's run it through the testing suite to make sure we don't have any text-based tests which fail before merging, though.
| @@ -201,8 +201,6 @@ static char *parse_options(const char *data, int *filesys_flags) | |||
| skip = 0; | |||
| } else { | |||
| skip = 0; | |||
| if (verboseflag) | |||
| printf("ceph: Unknown mount option %s\n",data); | |||
There was a problem hiding this comment.
Now that I look, I don't know... the verboseflag was set, so I think it's entirely reasonable to inform that the mount helper did not recognize the option. If we're worried about those sorts of messages then we shouldn't specify -v when mounting.
The message could be more clear though. For one thing, we should probably make it clear that it comes from "mount.ceph" and not "ceph". It should also go to stderr, IMO. Maybe:
fprintf(stderr, "mount.ceph: unrecognized mount option \"%s\", passing to kernel.\n", data);
...just to make it clear that it's not necessarily a problem.
The old message sounded worse than it really was, and was going to stdout instead of stderr. Fixes: http://tracker.ceph.com/issues/18159 Signed-off-by: John Spray <john.spray@redhat.com>
|
Updated |
|
@jtlayton look good? |
If these options were really unknown to the kernel client,
we would quickly find out when it returned an error. No need
to mention them in the output of the userspace tool.
Fixes: http://tracker.ceph.com/issues/18159
Signed-off-by: John Spray john.spray@redhat.com