New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: simplify find_package jemalloc #12468

Merged
merged 1 commit into from Dec 24, 2016

Conversation

Projects
None yet
3 participants
@bassam
Member

bassam commented Dec 13, 2016

the find_package for jemalloc seems overly complicated and does not seem to find jemalloc in common places like /usr/<cross_triple>/lib. I modified it to match the one used by rocksdb to find jemalloc (See src/rocksdb/cmake/modules/findjemalloc.cmake).

JEMALLOC_INCLUDE_DIR
JEMALLOC_LIBRARY
)
JEMALLOC_LIBRARIES)

This comment has been minimized.

@tchaikov

tchaikov Dec 13, 2016

Contributor

might need to update src/CMakeLists.txt accordingly.

This comment has been minimized.

@bassam

bassam Dec 13, 2016

Member

fixed.

@tchaikov

need to update src/CMakeLists.txt also.

cmake: simplify find_package jemalloc
simplified the package to find jemalloc. this one matches
the one in src/rocksdb/cmake/modules. The existing one
was struggling to find jemalloc on some hosts.

Signed-off-by: Bassam Tabbara <bassam.tabbara@quantum.com>

@liewegas liewegas merged commit 408c24d into ceph:master Dec 24, 2016

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@bassam bassam deleted the bassam:pr-simplify-jemalloc branch Jan 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment