journal: avoid logging an error when a watch is blacklisted #12473

Merged
merged 1 commit into from Dec 14, 2016

Projects

None yet

2 participants

@dillaman
Contributor

Fixes: http://tracker.ceph.com/issues/18243
Signed-off-by: Jason Dillaman dillaman@redhat.com

@dillaman dillaman journal: avoid logging an error when a watch is blacklisted
Fixes: http://tracker.ceph.com/issues/18243
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
b82a1c1
@trociny

LGTM

@trociny trociny self-assigned this Dec 13, 2016
@trociny trociny merged commit a1a2f3a into ceph:master Dec 14, 2016

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@dillaman dillaman deleted the dillaman:wip-18243 branch Dec 14, 2016
@trociny
Contributor
trociny commented Dec 14, 2016

@dillaman I have reproduced it again and just realized that the repeating errors come from handle_watch_reset, not handle_watch_error. I think, may be it makes sense to report "client blacklisted" with error level in handle_watch_error (as it would show only once and might be useful for user) and with debug level in handle_watch_reset?

@dillaman
Contributor

@trociny thanks -- sounds like a good plan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment