Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: fix hard coded boost python lib #12480

Merged
merged 1 commit into from Dec 29, 2016

Conversation

Projects
None yet
4 participants
@dx9
Copy link
Contributor

dx9 commented Dec 14, 2016

No description provided.

cmake: fix hard coded boost python lib
When using in tree boost build, linking will fail if boost is not installed.

Signed-off-by: John Coyle <dx9err@gmail.com>
@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Dec 14, 2016

retest this please (DNS failure on jenkins)

@liewegas liewegas requested a review from tchaikov Dec 29, 2016

@tchaikov tchaikov merged commit bc81c1b into ceph:master Dec 29, 2016

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov self-assigned this Dec 29, 2016

@wjwithagen

This comment has been minimized.

Copy link
Contributor

wjwithagen commented on 072c8b7 Jan 3, 2017

@dx9
I'm having trouble on FreeBSD to get this compiled.
So can you tell me where ${Boost_PYTHON_LIBRARY} gets defined in your build-environment?

This comment has been minimized.

Copy link
Contributor

tchaikov replied Jan 3, 2017

@wjwithagen ${Boost_PYTHON_LIBRARY} is defined by FindBoost.cmake, which should be shipped along with cmake or cmake-data.

#   Boost_<C>_FOUND        - True if component <C> was found (<C> is upper-case)
#   Boost_<C>_LIBRARY      - Libraries to link for component <C> (may include
#                            target_link_libraries debug/optimized keywords)

This comment has been minimized.

Copy link
Contributor

wjwithagen replied Jan 3, 2017

@tchaikov
I was afraid that that was the answer.
So now I have to figure out why that does not work on FreeBSD.
The python stuff is in a different package.

But it is definitely not in FindBoost.cmake per default. And the process to get it working is not quite clear to me yet.

This comment has been minimized.

Copy link
Contributor

wjwithagen replied Jan 3, 2017

@tchaikov
I've added some code to the WITH_MGR block, to make sure that FreeBSD will build.
Once that is in, I think FreeBSD will even build ceph-mgr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.