Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: fix the cross-quota rename boundary check conditions #12489

Merged
merged 1 commit into from Jan 27, 2017

Conversation

Projects
None yet
3 participants
@gregsfortytwo
Copy link
Member

gregsfortytwo commented Dec 14, 2016

We were previously rejecting a rename if either of the involved directories
was a quota root, even if the other directory was part of the same quota
"tree". What we really want to do is identify the correct quota root
(whether local or ancestral) for each directory and compare them. So
now we do.

Signed-off-by: Greg Farnum gfarnum@redhat.com

@jcsp

This comment has been minimized.

Copy link
Contributor

jcsp commented Dec 26, 2016

This isn't building (typo use of CInode instead of client inode class)

@jcsp

This comment has been minimized.

Copy link
Contributor

jcsp commented Jan 12, 2017

@ukernel

This comment has been minimized.

Copy link
Member

ukernel commented Jan 12, 2017

The idea looks good

client: fix the cross-quota rename boundary check conditions
We were previously rejecting a rename if either of the involved directories
was a quota root, even if the other directory was part of the same quota
"tree". What we really want to do is identify the correct quota root
(whether local or ancestral) for each directory and compare them. So
now we do.

Signed-off-by: Greg Farnum <gfarnum@redhat.com>

@gregsfortytwo gregsfortytwo force-pushed the gregsfortytwo:wip-fix-rename-bounds branch from 43d2afc to df2ba09 Jan 12, 2017

@gregsfortytwo

This comment has been minimized.

Copy link
Member Author

gregsfortytwo commented Jan 12, 2017

Updated. Made sure it builds this time, too, although obviously it doesn't come with a test. ;)

@gregsfortytwo gregsfortytwo force-pushed the gregsfortytwo:wip-fix-rename-bounds branch from df2ba09 to 8e8892a Jan 12, 2017

@jcsp jcsp merged commit 954a265 into ceph:master Jan 27, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.