New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: fix potential buffer overflow #12515

Merged
merged 2 commits into from Jan 9, 2017

Conversation

Projects
None yet
3 participants
@wwformat
Contributor

wwformat commented Dec 16, 2016

Trace::peek_string try to fill char *buf without any length check.
I think string buf is the better way to handle it.

Signed-off-by: Yunchuan Wen yunchuan.wen@kylin-cloud.com

wwformat added some commits Dec 16, 2016

client: fix potential buffer overflow
Trace::peek_string try to fill char *buf without any length check.
I think string buf is the better way to handle it.

Signed-off-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com>
client: use new Trace interface
Signed-off-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com>
@liewegas

This comment has been minimized.

Member

liewegas commented Dec 16, 2016

@jcsp Hmm this Trace code was added in the beginning so that I could capture a workload with ceph-fuse and replay it with SyntheticClient. We might want to just rip it out...

@jcsp jcsp merged commit 411bd53 into ceph:master Jan 9, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment