New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messages/MOSDPGTrim: add the missed HEAD_VERSION AND COMPAT_VERSION #12517

Merged
merged 1 commit into from Dec 24, 2016

Conversation

Projects
None yet
2 participants
@hjwsm1989
Contributor

hjwsm1989 commented Dec 16, 2016

@hjwsm1989

This comment has been minimized.

Contributor

hjwsm1989 commented Dec 16, 2016

@athanatos need you review

@@ -31,7 +31,7 @@ class MOSDPGTrim : public Message {
MOSDPGTrim() : Message(MSG_OSD_PG_TRIM, HEAD_VERSION, COMPAT_VERSION) {}
MOSDPGTrim(version_t mv, spg_t p, eversion_t tt) :
Message(MSG_OSD_PG_TRIM),
Message(MSG_OSD_PG_TRIM, HEAD_VERSION, COMPAT_VERSION),

This comment has been minimized.

@liewegas

liewegas Dec 16, 2016

Member

@athanatos doesn't this mean that outgoing messages haven't had version = 2, which means that on receipt, we've always been dropping the shard id? Which means that.. marking unfound objects lost is broken on EC pools?

This comment has been minimized.

@liewegas

liewegas Dec 16, 2016

Member

Oh nevermind, this is PG log trimming. Hmm.

@liewegas liewegas changed the title from messages/MOSDPGTrim: add the missed HEAD_VERSION AND COMPAT_VERSION to messages/MOSDPGTrim: add the missed HEAD_VERSION AND COMPAT_VERSION Dec 24, 2016

@liewegas liewegas merged commit 2377a1d into ceph:master Dec 24, 2016

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@hjwsm1989 hjwsm1989 deleted the hjwsm1989:wip-18266 branch Dec 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment