New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/admin-socket: fix potential buffer overflow #12518

Merged
merged 2 commits into from Dec 24, 2016

Conversation

Projects
None yet
3 participants
@wwformat
Contributor

wwformat commented Dec 16, 2016

Add code to ensure cmd[pos] is valid memory.

Signed-off-by: Yunchuan Wen yunchuan.wen@kylin-cloud.com

admin-socket: fix potential buffer overflow
Add code to ensure cmd[pos] is valid memory.

Signed-off-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com>
@liewegas

This comment has been minimized.

Member

liewegas commented Dec 16, 2016

Is it worth adding a unit test case?

test: add new testcase for request admin_socket with long request
Signed-off-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com>
@wwformat

This comment has been minimized.

Contributor

wwformat commented Dec 17, 2016

Is it worth adding a unit test case?

@liewegas
OK, already uploaded.

@hjwsm1989

This comment has been minimized.

Contributor

hjwsm1989 commented Dec 17, 2016

nice catch

@liewegas liewegas changed the title from admin-socket: fix potential buffer overflow to common/admin-socket: fix potential buffer overflow Dec 22, 2016

@liewegas liewegas merged commit 8343d21 into ceph:master Dec 24, 2016

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment