New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/ECBackend: Send write message to peers first, then do local write #12522

Merged
merged 1 commit into from Dec 29, 2016

Conversation

Projects
None yet
3 participants
@hjwsm1989
Contributor

hjwsm1989 commented Dec 16, 2016

Like ReplicatedBackend did, this will improve write performance.

Signed-off-by: huangjun hjwsm1989@gmail.com

osd/ECBackend: Send write message to peers first, then do local write
  Like ReplicatedBackend did, this will improve write performance.

  Signed-off-by: huangjun <hjwsm1989@gmail.com>
@hjwsm1989

This comment has been minimized.

Contributor

hjwsm1989 commented Dec 16, 2016

as discussed in #11888

@hjwsm1989

This comment has been minimized.

Contributor

hjwsm1989 commented Dec 17, 2016

@athanatos please review it

@athanatos

This comment has been minimized.

Contributor

athanatos commented Dec 19, 2016

I'm really not convinced that this makes a difference. The local write and message sends here are async.

@athanatos

This comment has been minimized.

Contributor

athanatos commented Dec 19, 2016

Please reopen if there is evidence that it makes a difference.

@athanatos athanatos closed this Dec 19, 2016

@liewegas

This comment has been minimized.

Member

liewegas commented Dec 19, 2016

With bluestore a non-trivial amount of work is now happening in queue_transaction (everything but io). Is there a downside to doing this? It can't hurt

@athanatos athanatos reopened this Dec 19, 2016

@athanatos

This comment has been minimized.

Contributor

athanatos commented Dec 19, 2016

Ok, that's a valid reason!

@hjwsm1989

This comment has been minimized.

Contributor

hjwsm1989 commented Dec 22, 2016

did the failed test related to this PR?

@liewegas

This comment has been minimized.

Member

liewegas commented Dec 28, 2016

retest this please

@liewegas liewegas changed the title from osd/ECBackend: Send write message to peers first, then do local write to osd/ECBackend: Send write message to peers first, then do local write Dec 29, 2016

@liewegas liewegas merged commit 2c05a96 into ceph:master Dec 29, 2016

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@hjwsm1989 hjwsm1989 deleted the hjwsm1989:ecwrite branch Dec 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment