Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/filestore/JournalingObjectStore cleanup #12528

Merged
merged 3 commits into from Dec 29, 2016

Conversation

Projects
None yet
2 participants
@dragonylffly
Copy link
Contributor

dragonylffly commented Dec 16, 2016

No description provided.

dragonylffly added some commits Dec 16, 2016

JournalingObjectStore: skip journal commit_start if commit_start does…
… nothing

Signed-off-by: Li Wang <li.wang@kylin-cloud.com>
JournalingObjectStore: remove unneeded variable
Signed-off-by: Li Wang <li.wang@kylin-cloud.com>
JournalingObjectStore: remove misleading comments
Prior to start journal commit, it always needs to wait the ongoing apply
operation to finish, not only needed during journal replay. Between
commit_start() and commit_started(), it always needs to prevent starting
apply, not only needed during journal replay.

Signed-off-by: Li Wang <li.wang@kylin-cloud.com>

@liewegas liewegas changed the title JournalingObjectStore cleanup os/filestore/JournalingObjectStore cleanup Dec 16, 2016

@liewegas
Copy link
Member

liewegas left a comment

lgtm!

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Dec 23, 2016

retest this please

@liewegas liewegas merged commit 2bdb569 into ceph:master Dec 29, 2016

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.