New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cls/rgw: Clean up the "magic string" usage in the cls layer for RGW. #12536

Merged
merged 1 commit into from Apr 17, 2017

Conversation

Projects
None yet
6 participants
@ilc

ilc commented Dec 16, 2016

This set of changes, should make following what is going on across the cls
barrier much easier for people using code browsing tools.

Signed-off-by: Ira Cooper ira@redhat.com

Ira Cooper
cls/rgw: Clean up the "magic string" usage in the cls layer for RGW.
This set of changes, should make following what is going on across the cls
barrier much easier for people using code browsing tools.

Signed-off-by: Ira Cooper <ira@redhat.com>
@adamemerson

Looks reasonable, and makes use of any method or class easier to find in cscope or similar.

#define RGW_LC_PUT_HEAD "lc_put_head"
#define RGW_LC_GET_HEAD "lc_get_head"
#define RGW_LC_LIST_ENTRIES "lc_list_entries"

This comment has been minimized.

@adamemerson

adamemerson Dec 16, 2016

Contributor

I might be tempted to favor constexpr over define myself for these, but that's a matter of taste more than anything.

This comment has been minimized.

@mattbenjamin

mattbenjamin Dec 16, 2016

Contributor

Just to clarify, a constexpr array of char, or something else? (I'm still in the pre-processor era, for this application...)

This comment has been minimized.

@adamemerson

adamemerson Dec 16, 2016

Contributor

Just a char*

@liewegas liewegas added the cleanup label Dec 16, 2016

@liewegas

This comment has been minimized.

Member

liewegas commented Dec 16, 2016

looks ok to me

@ilc

This comment has been minimized.

ilc commented Dec 16, 2016

In this case... I'd like to leave the header file open to C users, if the APIs to use it exist. (Even if not, they may in the future.) Remember we have librgwfile already, and other C libraries.

@ilc

This comment has been minimized.

ilc commented Dec 19, 2016

Can we get this merged?

@mattbenjamin

This comment has been minimized.

Contributor

mattbenjamin commented Jan 8, 2017

@ilc probably mid next week, hipriority has been closing out final K blockers (one merged today)

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Mar 1, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 10, 2017

@cbodley

passed rgw suite: http://pulpito.ceph.com/cbodley-2017-04-12_16:19:10-rgw-wip-cbodley-testing---basic-mira/ (single swift test failure appeared to be a spurious network issue. valgrind issues were in osd and mon)

@cbodley cbodley merged commit ac77cad into ceph:master Apr 17, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@cbodley

This comment has been minimized.

Contributor

cbodley commented Apr 17, 2017

thanks @ilc, sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment