New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: fix force_pg_create pg stuck in creating bug #12539

Merged
merged 3 commits into from Feb 9, 2017

Conversation

Projects
None yet
5 participants
@liewegas
Member

liewegas commented Dec 16, 2016

http://tracker.ceph.com/issues/18298

Also clean out some more legacy crud we don't need.

// the cluster. As soon as everybody has upgraded we can flipt to the new
// behavior instead
OSDMap& osdmap = mon->osdmon()->osdmap;
if (osdmap.get_num_up_osds() == 0)

This comment has been minimized.

@songbaisen

songbaisen Dec 20, 2016

should we still keep this check?

@liewegas

This comment has been minimized.

Member

liewegas commented Dec 20, 2016

@liewegas liewegas requested a review from jecluis Jan 19, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Jan 31, 2017

@tchaikov rebased this on master

@tchaikov tchaikov self-assigned this Jan 31, 2017

@jecluis

meh, looked at this last week and then forgot to add the review.

lgtm.

@liewegas liewegas added the needs-qa label Jan 31, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Jan 31, 2017

retest this please

@liewegas

This comment has been minimized.

Member

liewegas commented Feb 1, 2017

retest this please

if (osdmap.get_num_up_osds() > 0) {
assert(osdmap.get_up_osd_features() & CEPH_FEATURE_MON_STATEFUL_SUB);
}
check_subs();

This comment has been minimized.

@tchaikov

tchaikov Feb 6, 2017

Contributor

could move check_subs() into the if (osdmap.get_num_up_osds() > 0) block, because only OSD is interested in the pg creates updates.

liewegas added some commits Dec 16, 2016

mon/MonCommands: remove send_pg_creates from cmd table
Forgot this in 6cbdd67

Signed-off-by: Sage Weil <sage@redhat.com>
mon/PGMonitor: clean up some send_pg_creates cruft
ff1fd4b already removed most of
this; remove the now useless stub and clean up the unneede con
check.

Signed-off-by: Sage Weil <sage@redhat.com>
mon/PGMonitor: fix force_create_pg
We weren't carefully registering the creating PG.  In
particular, the current osd mappings (acting, up, etc.)
weren't getting filled in, which meant the PG wasn't
(necessarily) mapped to an OSD until the OSDMap updated
and we recalculated mappings.

Fix by sending us through the common code path so that
all fields get updated properly.

Fixes: http://tracker.ceph.com/issues/18298
Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas

This comment has been minimized.

Member

liewegas commented Feb 6, 2017

@liewegas liewegas merged commit 4d505ac into ceph:master Feb 9, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@liewegas liewegas deleted the liewegas:wip-mon-pg-creates branch Feb 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment