Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg/async: assert if compiled code doesn't support the configured ms_… #12559

Merged
merged 1 commit into from Dec 23, 2016

Conversation

Projects
None yet
4 participants
@Adirl
Copy link

Adirl commented Dec 18, 2016

…async_transport_type

for example, currently there is a crash when using the async stack (access of null pointer)
in case the user configured rdma for a code that was not compiled with RDMA

Signed-off-by: Avner BenHanoch avnerb@mellanox.com

@Adirl

This comment has been minimized.

Copy link
Author

Adirl commented Dec 18, 2016

@yuyuyu101 please take a look

@saritz
@DanielBo

@@ -68,6 +68,9 @@ std::shared_ptr<NetworkStack> NetworkStack::create(CephContext *c, const string
return std::make_shared<DPDKStack>(c, t);
#endif

lderr(c) << __func__ << " ms_async_transport_type " << t <<
" is not valid in this version of ceph" << dendl;

This comment has been minimized.

Copy link
@yuyuyu101

yuyuyu101 Dec 19, 2016

Member

maybe not related to version because built without ENABLE_XXX, " xxx isn't supported?"

This comment has been minimized.

Copy link
@Adirl

Adirl Dec 21, 2016

Author

done

@yuyuyu101

This comment has been minimized.

Copy link
Member

yuyuyu101 commented Dec 22, 2016

plz sqush these

@Adirl Adirl force-pushed the Adirl:verify_transport_type branch 2 times, most recently from 1f13900 to d58175d Dec 22, 2016

@Adirl

This comment has been minimized.

Copy link
Author

Adirl commented Dec 22, 2016

Done

@@ -68,6 +68,9 @@ std::shared_ptr<NetworkStack> NetworkStack::create(CephContext *c, const string
return std::make_shared<DPDKStack>(c, t);
#endif

lderr(c) << __func__ << " ms_async_transport_type " << t <<
" is not supported! " << dendl;
assert(! "ms_async_transport_type should contain a supported value");

This comment has been minimized.

Copy link
@yuyuyu101

yuyuyu101 Dec 22, 2016

Member

ceph_abort() maybe better...

msg/async: assert if compiled code doesn't support the configured ms_…
…async_transport_type

for example, currently there is a crash when using the async stack (access of null pointer)
in case the user configured rdma for a code that was not compiled with RDMA

issue: 913397

Change-Id: I4e3d88006312a713b8d3aaefbdcd0596039270e1
Signed-off-by: Avner BenHanoch <avnerb@mellanox.com>

@Adirl Adirl force-pushed the Adirl:verify_transport_type branch from d58175d to e3b744a Dec 23, 2016

@Adirl

This comment has been minimized.

Copy link
Author

Adirl commented Dec 23, 2016

done

@yuyuyu101 yuyuyu101 merged commit 9dc43d3 into ceph:master Dec 23, 2016

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@Adirl Adirl deleted the Adirl:verify_transport_type branch Apr 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.