New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocksdb: add option: writable_file_max_buffer_size = 0 #12562

Merged
merged 1 commit into from Jan 5, 2017

Conversation

Projects
None yet
3 participants
@majianpeng
Member

majianpeng commented Dec 19, 2016

@liewegas liewegas added bluestore core needs-qa and removed core labels Dec 19, 2016

rocksdb: add option: writable_file_max_buffer_size = 0
This reduce memcopy between rocksdb and bluefs.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Dec 20, 2016

Member

We should either backport this patch to our rocksdb submodule, or (better yet?) just fast-forward to a newer upstream rocksdb commit. Let's do it right after kraken, though, so we don't release with an untested rocksdb version.

Member

liewegas commented Dec 20, 2016

We should either backport this patch to our rocksdb submodule, or (better yet?) just fast-forward to a newer upstream rocksdb commit. Let's do it right after kraken, though, so we don't release with an untested rocksdb version.

@tchaikov tchaikov merged commit 053d40f into ceph:master Jan 5, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@tchaikov

This comment has been minimized.

Show comment
Hide comment
@tchaikov

tchaikov Jan 5, 2017

Contributor

@majianpeng @liewegas do we need a tracker ticket targeting kraken for this issue?

Contributor

tchaikov commented Jan 5, 2017

@majianpeng @liewegas do we need a tracker ticket targeting kraken for this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment