New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: make attempts of auth rotating configurable #12563

merged 2 commits into from Dec 24, 2016


None yet
2 participants

xiexingguo commented Dec 19, 2016

And make attempts of auth rotating configurable.

@xiexingguo xiexingguo requested a review from liewegas Dec 19, 2016

delete f;
*_dout << dendl;
if (g_conf->osd_dump_op_queue) {
lgeneric_subdout(osd->cct, osd, 30) << "dequeue status: ";

This comment has been minimized.


liewegas Dec 19, 2016


This isn't necessary. The dout macros are a conditional on the debug level and open a set of braces that are later closed by dendl. Anything between the initial dout (or variant) and dendl macros is conditional.

This comment has been minimized.


xiexingguo Dec 20, 2016


Got it. Updated.


This comment has been minimized.


liewegas commented Dec 19, 2016

The other two patches look ok! Thanks

@xiexingguo xiexingguo changed the title from osd: conditionally dump op workqueue to common: make attempts of auth rotating configurable Dec 20, 2016

xiexingguo added some commits Dec 17, 2016

common: make attempts of auth rotating configurable
Signed-off-by: xie xingguo <>
osd/OSDMap: drop redundant statements
calc_pg_rank() will do the same check inside.

Signed-off-by: xie xingguo <>

@liewegas liewegas merged commit 42c33ed into ceph:master Dec 24, 2016

3 checks passed

Signed-off-by all commits in this PR are signed
Unmodifed Submodules submodules for project are unmodified
default Build finished.

@xiexingguo xiexingguo deleted the xiexingguo:xxg-wip-osd-1217 branch Dec 24, 2016

smithfarm pushed a commit to SUSE/ceph that referenced this pull request Dec 27, 2016

suites/hammer/older: do not upgrade client while running RBD import/e…

Between the Giant and Hammer releases, the symbols exported from librados/librbd
were cleaned up.  This creates a short window of time between installing
upgraded packages where symbol lookup errors could occur.

Fixes: ceph#12563
Signed-off-by: Jason Dillaman <>
(cherry picked from commit cb7eb2a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment