New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore/bluestore_types: drop std::bitset for blob unused #12569

Merged
merged 2 commits into from Dec 27, 2016

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented Dec 19, 2016

The complex type screws up struct packing. This takes
bluestore_blob_t from 64 to 56 bytes.

Signed-off-by: Sage Weil sage@redhat.com

@varadakari

LGTM

@liewegas liewegas self-assigned this Dec 20, 2016

liewegas added some commits Dec 19, 2016

os/bluestore/bluestore_types: drop std::bitset for blob unused
The complex type screws up struct packing.  This takes
bluestore_blob_t from 64 to 56 bytes.

Signed-off-by: Sage Weil <sage@redhat.com>
os/bluestore/bluestore_types: reorder onode_t types
Save 8 bytes.

Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Dec 20, 2016

Member
Member

liewegas commented Dec 20, 2016

@ifed01

ifed01 approved these changes Dec 20, 2016

@liewegas liewegas merged commit c67a235 into ceph:master Dec 27, 2016

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@liewegas liewegas deleted the liewegas:wip-bluestore-raw-unused branch Dec 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment