New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstart: start radosgw-all according to runlevel #12586

Merged
merged 1 commit into from Feb 8, 2017

Conversation

Projects
None yet
4 participants
@ktdreyer
Member

ktdreyer commented Dec 20, 2016

Prior to this change, the radosgw-all service depended on the ceph-all service in order to trigger a start operation. ceph-all.conf ships in the ceph-base package. This means that radosgw-all Upstart service would not start on boot unless the ceph-base package was also installed.

Break this dependency by starting radosgw-all according to the system's runlevel, rather than only listening for the ceph-all starting signal.

This change causes RGW to start on boot even when ceph-base is not installed.

Preserve the original on starting ceph-all condition here as well, so that users can still start RGW with the documented start ceph-all command.

(Note: This has the side effect that if a user has a "ceph-all.override -> manual" file on their system because they intentionally wanted to prevent all Ceph-related services from starting during boot, RGW will still start on boot when it did not previously. Users will need to explicitly create a "radosgw-all.override -> manual" file as well if they want to prevent RGW from starting on boot.)

Fixes: http://tracker.ceph.com/issues/18313

@ktdreyer ktdreyer requested review from liewegas and javacruft Dec 20, 2016

@liewegas

LGTM. Note that this is upstart, which nobody is using going forward, so this is only really useful for old distros and releases.

@ktdreyer ktdreyer added the build/ops label Dec 20, 2016

upstart: start radosgw-all according to runlevel
Prior to this change, the radosgw-all service depended on the ceph-all
service in order to trigger a start operation. ceph-all.conf ships in
the ceph-base package. This means that "radosgw-all" Upstart service
would not start on boot unless the "ceph-base" package was also
installed.

Break this dependency by starting radosgw-all according to the system's
runlevel, rather than only listening for the ceph-all starting signal.

This change causes RGW to start on boot even when ceph-base is not
installed.

Preserve the original "on starting ceph-all" condition here as well, so
that users can still start RGW with the documented "start ceph-all"
command.

(Note: This has the side effect that if a user has a "ceph-all.override
-> manual" file on their system because they intentionally wanted to
prevent all Ceph-related services from starting during boot, RGW will
still start on boot when it did not previously. Users will need to
explicitly create a "radosgw-all.override -> manual" file as well if
they want to prevent RGW from starting on boot.)

Fixes: http://tracker.ceph.com/issues/18313

Signed-off-by: Ken Dreyer <kdreyer@redhat.com>

@tchaikov tchaikov merged commit d25b355 into ceph:master Feb 8, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@ktdreyer ktdreyer deleted the ktdreyer:wip-18313-rgw-upstart branch Feb 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment