Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/ReplicatedBackend: do not set omap header if it is empty #12612

Merged
merged 1 commit into from Dec 27, 2016

Conversation

Projects
None yet
5 participants
@fangyuxiangGL
Copy link
Contributor

fangyuxiangGL commented Dec 22, 2016

In replicatedpg backfill, objects have no omap header or keys previously, but an empty omap header will be inserted when they are pushed to replica, which leads leveldb performance degrade seriously when cluster has huge number of objects.
so my opinion is that we does't insert omap header if is size is zero when handle PushOp in recovery.
Signed-off-by: fangyuxiang fang.yuxiang@eisoo.com

@fangyuxiangGL

This comment has been minimized.

Copy link
Contributor Author

fangyuxiangGL commented Dec 22, 2016

Signed-off-by: fangyuxiang fang.yuxiang@eisoo.com

@fangyuxiangGL fangyuxiangGL reopened this Dec 22, 2016

@hjwsm1989

This comment has been minimized.

Copy link
Contributor

hjwsm1989 commented Dec 22, 2016

you should add the "Signed-off-by: xxx" line to your commit meesage,
check other PRs

@hjwsm1989

This comment has been minimized.

Copy link
Contributor

hjwsm1989 commented Dec 22, 2016

and dont close/reopen the pr,
you can use "git push -f" to force update

@fangyuxiangGL fangyuxiangGL force-pushed the fangyuxiangGL:master branch from a134088 to b3ca8a5 Dec 22, 2016

@fangyuxiangGL

This comment has been minimized.

Copy link
Contributor Author

fangyuxiangGL commented Dec 22, 2016

@fangyuxiangGL

This comment has been minimized.

Copy link
Contributor Author

fangyuxiangGL commented Dec 22, 2016

@hjwsm1989 could you tell me how can i invite a reviewer for this pr? thx

@fangyuxiangGL

This comment has been minimized.

Copy link
Contributor Author

fangyuxiangGL commented Dec 27, 2016

@liewegas

Hi, sage

could you review for me? first PR, thx :-)

@yuyuyu101 yuyuyu101 added the needs-qa label Dec 27, 2016

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Dec 27, 2016

could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes, in this case, it would be "ReplicatedBackend:".

and you could shorten the title of your commit message to something like:

ReplicatedBackend: do not set omap header if it is empty

and put more details in the body of the commit message.

also, you might want to add brackets around your mail address in your commit message like

Signed-off-by: fang yuxiang fang.yuxiang@eisoo.com

"git commit -s" will do this for you.

@fangyuxiangGL

This comment has been minimized.

Copy link
Contributor Author

fangyuxiangGL commented Dec 27, 2016

@tchaikov ok, thanks for your remind

@fangyuxiangGL fangyuxiangGL changed the title No need to insert empty omap header in replicatedpg recovery ReplicatedBackend: do not set omap header if it is empty Dec 27, 2016

@fangyuxiangGL fangyuxiangGL force-pushed the fangyuxiangGL:master branch from b3ca8a5 to 0b573bb Dec 27, 2016

ReplicatedBackend: do not set omap header if it is empty
In replicatedpg backfill, objects have no omap header or keys previously, but an empty omap header will be inserted when they are pushed to replica, which leads leveldb performance degrade seriously when cluster has huge number of objects.
so my opinion is that we does't insert omap header if is size is zero when handle PushOp in recovery.

Signed-off-by: fang yuxiang <fang.yuxiang@eisoo.com>

@fangyuxiangGL fangyuxiangGL force-pushed the fangyuxiangGL:master branch from 0b573bb to c0ddd39 Dec 27, 2016

@fangyuxiangGL

This comment has been minimized.

Copy link
Contributor Author

fangyuxiangGL commented Dec 27, 2016

@tchaikov amended the commit message as the rule, thx

@liewegas liewegas changed the title ReplicatedBackend: do not set omap header if it is empty osd/ReplicatedBackend: do not set omap header if it is empty Dec 27, 2016

@liewegas liewegas merged commit bb28192 into ceph:master Dec 27, 2016

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.