New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/cmake: provide asan, tsan, ubsan builds #12615

Merged
merged 1 commit into from Jan 13, 2017

Conversation

Projects
None yet
5 participants
@mattbenjamin
Contributor

mattbenjamin commented Dec 22, 2016

The options are taken from rocksdb, but updated to match the
instructions here:

https://gist.github.com/kwk/4171e37f4bcdf7705329

Signed-off-by: Matt Benjamin mbenjamin@redhat.com

@mattbenjamin

This comment has been minimized.

Show comment
Hide comment
@mattbenjamin

mattbenjamin Dec 22, 2016

Contributor

@dang and the nfs-ganesha team used this to good effect this week, so I tried it w/AioCompletion use-after-free and it delivers the goods fast.

Contributor

mattbenjamin commented Dec 22, 2016

@dang and the nfs-ganesha team used this to good effect this week, so I tried it w/AioCompletion use-after-free and it delivers the goods fast.

Show outdated Hide outdated CMakeLists.txt
Show outdated Hide outdated CMakeLists.txt
@tchaikov

This comment has been minimized.

Show comment
Hide comment
@tchaikov

tchaikov Dec 27, 2016

Contributor

retest this please (jenkins not finished)

Contributor

tchaikov commented Dec 27, 2016

retest this please (jenkins not finished)

@tchaikov tchaikov self-assigned this Dec 27, 2016

build/cmake: provide asan, tsan, ubsan builds
The options are taken from rocksdb, but updated to match the
instructions here:

https://gist.github.com/kwk/4171e37f4bcdf7705329

Added option to explicitly enable leak checking via
-fsanitize-leak, after review.  The behavior I've observed from
-fsanitize-address and libasan linkage included leak checking,
but perhaps this is not general or changing behavior.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
if(WITH_ASAN_LEAK)
set(ASAN_CFLAGS "${ASAN_CFLAGS} -fsanitize=leak")
endif()
set(ASAN_LFLAGS "${CMAKE_EXE_LINKER_FLAGS} ${ASAN_CFLAGS} -lasan")

This comment has been minimized.

@tchaikov

tchaikov Jan 5, 2017

Contributor

nit, -fno-omit-frame-pointer is not understood by the linker.

@tchaikov

tchaikov Jan 5, 2017

Contributor

nit, -fno-omit-frame-pointer is not understood by the linker.

@dang

dang approved these changes Jan 13, 2017

@tchaikov tchaikov merged commit 4845541 into ceph:master Jan 13, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment