New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: ldap: simple_bind() should set ldap version option on tldap #12616

Merged
merged 1 commit into from Dec 22, 2016

Conversation

Projects
None yet
2 participants
@atheism
Contributor

atheism commented Dec 22, 2016

ldap_set_option() should set option for "tldap" other than "ldap".
The current code will lead to "Protocol error" as the ldap version
of tldap is not set.

Signed-off-by: Weibing Zhang zhangweibing@unitedstack.com

rgw: ldap: simple_bind() should set ldap option on tldap
    ldap_set_option() should set option for "tldap" other than "ldap".
    The current code will lead to "Protocol error" as the ldap version
    of tldap is not set.

Signed-off-by: Weibing Zhang <zhangweibing@unitedstack.com>

@atheism atheism changed the title from rgw: ldap: simple_bind() should set ldap option on tldap to rgw: ldap: simple_bind() should set ldap version option on tldap Dec 22, 2016

@atheism

This comment has been minimized.

Contributor

atheism commented Dec 22, 2016

Here is the error message:
2016-12-22 15:51:01.057637 7fcb3d7e2700 15 authorize_v2 LDAP auth uri=ldap://192.168.0.12:389
2016-12-22 15:51:01.057769 7fcb3d7e2700 10 authorize_v2 try LDAP auth uri=ldap://192.168.0.12:389 token.id=ldap-cepher
2016-12-22 15:51:01.057783 7fcb3d7e2700 12 auth search filter: (uid=ldap-cepher)
2016-12-22 15:51:25.629715 7fcb7effd700 2 RGWDataChangesLog::ChangesRenewThread: start
2016-12-22 15:51:16.164399 7fcb3d7e2700 10 auth simple_bind failed uid=ldap-cepher
simple_bind() failed here.

@mattbenjamin mattbenjamin self-assigned this Dec 22, 2016

@mattbenjamin

This comment has been minimized.

Contributor

mattbenjamin commented Dec 22, 2016

Strange, this looks identical to a fixed bug. Maybe auth rework re-introduced it.

@mattbenjamin

This comment has been minimized.

Contributor

mattbenjamin commented Dec 22, 2016

@mattbenjamin mattbenjamin requested a review from yehudasa Dec 22, 2016

@mattbenjamin

This comment has been minimized.

Contributor

mattbenjamin commented Dec 22, 2016

@yehudasa can we merge this now? need to create backports

@mattbenjamin mattbenjamin merged commit 566ad2d into ceph:master Dec 22, 2016

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment