New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: remove a never read value #12618

Merged
merged 1 commit into from Dec 22, 2016

Conversation

Projects
None yet
4 participants
@Liuchang0812
Contributor

Liuchang0812 commented Dec 22, 2016

Signed-off-by: liuchang0812 liuchang0812@gmail.com

BUILD PASS. @liewegas PTLK

os/bluestore: remove a never read value
Signed-off-by: liuchang0812 <liuchang0812@gmail.com>

@liewegas liewegas merged commit f884ad5 into ceph:master Dec 22, 2016

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@Liuchang0812 Liuchang0812 deleted the Liuchang0812:fix-blue-store-unused-var branch Dec 22, 2016

@Liuchang0812

This comment has been minimized.

Show comment
Hide comment
@Liuchang0812

Liuchang0812 Dec 22, 2016

Contributor

thanks you all

Contributor

Liuchang0812 commented Dec 22, 2016

thanks you all

uint64_t omap_head;
p = _key_decode_u64(p, &omap_head);
_key_decode_u64(key.c_str(), &omap_head);

This comment has been minimized.

@ifed01

ifed01 Dec 22, 2016

Contributor

One can remove key var as well and that's even more beneficial since string is copied there

@ifed01

ifed01 Dec 22, 2016

Contributor

One can remove key var as well and that's even more beneficial since string is copied there

This comment has been minimized.

@Liuchang0812

Liuchang0812 Dec 23, 2016

Contributor

@ifed01 xiexinguo fix this in #12643

@Liuchang0812

Liuchang0812 Dec 23, 2016

Contributor

@ifed01 xiexinguo fix this in #12643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment