Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
rbd: When Ceph cluster becomes full, should allow user to remove rbd … #12627
Right, but you shouldn't be reaching the failsafe condition. This is usually a much higher threshold than the osdmap cluster FULL flag that stops writes.. it's there to prevent some other process (errant backfill or something) from filling up an OSD. In theory it should never be triggered.
@liewegas, do you mean I need rename honor_osdmap_full or set_honor_osdmap_full()?
referenced this pull request
Feb 1, 2017
@liupan1111 I don't see any changes. I thought Sage was suggesting that you re-use the existing librados flag for allowing ops to proceed on full(?). Assuming that is the case, I think you would want to modify librbd to set the flag where needed when opening the image and set the flag on the individual ops issued on the remove / snap remove paths.
TestLibRBD.FlattenNoEmptyObjects failures unrelated, also on master per @jasondillaman
same job passed on manual rerun !
and confirmed pass