New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: do not cache shard keys #12634

Merged
merged 1 commit into from Dec 24, 2016

Conversation

Projects
None yet
4 participants
@liewegas
Member

liewegas commented Dec 22, 2016

No description provided.

@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Dec 23, 2016

Member
Member

liewegas commented Dec 23, 2016

@markhpc

This comment has been minimized.

Show comment
Hide comment
@markhpc

markhpc Dec 23, 2016

Member

This is resulting in at least a 10% performance improvement for 4K random writes and significant memory savings when using smaller shard_max / target sizes.

Member

markhpc commented Dec 23, 2016

This is resulting in at least a 10% performance improvement for 4K random writes and significant memory savings when using smaller shard_max / target sizes.

@allensamuels

This comment has been minimized.

Show comment
Hide comment
@allensamuels

allensamuels Dec 23, 2016

Member
Member

allensamuels commented Dec 23, 2016

@ifed01

This comment has been minimized.

Show comment
Hide comment
@ifed01

ifed01 Dec 23, 2016

Contributor

@liewegas - forget to push?

Contributor

ifed01 commented Dec 23, 2016

@liewegas - forget to push?

@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Dec 23, 2016

Member

@ifed01 nope, latest is pushed..

Member

liewegas commented Dec 23, 2016

@ifed01 nope, latest is pushed..

@ifed01

This comment has been minimized.

Show comment
Hide comment
@ifed01

ifed01 Dec 23, 2016

Contributor

That's strange, can't see neither my nor Allen's comment resolved...

Contributor

ifed01 commented Dec 23, 2016

That's strange, can't see neither my nor Allen's comment resolved...

os/bluestore: do not precalculate/cache shard keys
Note that we are generating it on demand now.  We can
probably do better, especially when in a loop.

Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Dec 23, 2016

Member

oops, there it is

Member

liewegas commented Dec 23, 2016

oops, there it is

@ifed01

ifed01 approved these changes Dec 23, 2016

@liewegas liewegas merged commit cf8161f into ceph:master Dec 24, 2016

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@liewegas liewegas deleted the liewegas:wip-bluestore-shard-keys branch Dec 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment