New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: don't continue to remove an image w/ incompatible features #12638

Merged
merged 1 commit into from Jan 6, 2017

Conversation

Projects
None yet
2 participants
@yangdongsheng
Member

yangdongsheng commented Dec 23, 2016

librbd: don't remove an image w/ incompatible features
Fixes: http://tracker.ceph.com/issues/18315
Signed-off-by: Dongsheng Yang <dongsheng.yang@easystack.cn>
@yangdongsheng

This comment has been minimized.

Member

yangdongsheng commented Dec 26, 2016

I don't think this is what Jason suggests as a fix for this issue. I had impression he wanted we check for incompatible features, while you just make it to abort when it fails to open the image.

@trociny IMO, the open operation will check the incompatible features, I want to reuse it. then abort the removal here. then it should be that:

if (r == -ENOSYS)
    return r;

But at the same time, I think we should only allow removal to continue when we got an -ENOENT in opening. So it turns out to be what it looks in this PR.

@dillaman

lgtm -- solves issues like permission problems, incompatible features, etc.

@dillaman dillaman merged commit 21a8c69 into ceph:master Jan 6, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment