Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg/async/rdma: fix RoCE v2 deafult value #12648

Merged
merged 1 commit into from Dec 26, 2016

Conversation

Projects
None yet
3 participants
@Adirl
Copy link

Adirl commented Dec 23, 2016

For backward compatibility, if no GID given or given GID is malformed,
use GID index 0.

Signed-off-by: Oren Duer oren@mellanox.com Adir Lev adirl@mellanox.com
Signed-off-by: Adir Lev adirl@mellanox.com

msg/async/rdma: fix RoCE v2 deafult value
For backward compatibility, if no GID given or given GID is malformed,
use GID index 0.

Change-Id: I8c8ecbcfc0261e58c5a226ef6bc91297ec756182
Signed-off-by: Oren Duer <oren@mellanox.com> Adir Lev <adirl@mellanox.com>
Signed-off-by: Adir Lev <adirl@mellanox.com>
@Adirl

This comment has been minimized.

Copy link
Author

Adirl commented Dec 23, 2016

@yuyuyu101 pls see fixes to RoceV2 support

@@ -224,7 +224,7 @@ OPTION(ms_async_rdma_receive_buffers, OPT_U32, 10240)
OPTION(ms_async_rdma_port_num, OPT_U32, 1)
OPTION(ms_async_rdma_polling_us, OPT_U32, 1000)
OPTION(ms_async_rdma_local_gid, OPT_STR, "") // GID format: "fe80:0000:0000:0000:7efe:90ff:fe72:6efe", no zero folding
OPTION(ms_async_rdma_roce_ver, OPT_INT, 2) // 2=RoCEv2, 1=RoCEv1.5, 0=RoCEv1
OPTION(ms_async_rdma_roce_ver, OPT_INT, 1) // 0=RoCEv1, 1=RoCEv2, 2=RoCEv1.5

This comment has been minimized.

Copy link
@yuyuyu101

yuyuyu101 Dec 23, 2016

Member

could we get roce version by giving local_gid? like cat from /sys?

This comment has been minimized.

Copy link
@yuyuyu101

yuyuyu101 Dec 23, 2016

Member

same for local gid, could we only set gid index and getting others by code?

I'm thinking to find a way let user could use auto deploy tool instead of configurate roce in each host

This comment has been minimized.

Copy link
@Adirl

Adirl Dec 25, 2016

Author

currently user must provide local_gid in ceph.conf per machine,
code does the rest according to the gid provided

RDMA-CM will solve all this issues and we can then use one conf for all.

This comment has been minimized.

Copy link
@Adirl

Adirl Dec 25, 2016

Author

using gid index could have been a good idea,
but... no guaranty on index ordering in machine and between machines
so we cannot rely on that

@yuyuyu101 yuyuyu101 merged commit 32378ad into ceph:master Dec 26, 2016

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@Adirl Adirl deleted the Adirl:fix_RoCEv2_deafult_value branch Apr 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.