New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/librados/c_read_operations.cc: Fix valgrind errors #12657

Merged
merged 1 commit into from Dec 26, 2016

Conversation

Projects
None yet
3 participants
@badone
Contributor

badone commented Dec 25, 2016

Fixes: http://tracker.ceph.com/issues/18354

Signed-off-by: Brad Hubbard bhubbard@redhat.com

@@ -51,7 +51,7 @@ class CReadOpsTest : public RadosTest {
const char *zeros[len];
size_t zero_lens[len];
memset(zeros, 0, len);
memset(zeros, 0, len * sizeof(char*));

This comment has been minimized.

@Liuchang0812

Liuchang0812 Dec 25, 2016

Contributor

why not memset(zeros, 0, sizeof zeros); ?

test/librados/c_read_operations.cc: Fix valgrind errors
Fixes: http://tracker.ceph.com/issues/18354

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
@badone

This comment has been minimized.

Contributor

badone commented Dec 25, 2016

@tchaikov

lgtm

@badone badone merged commit 2488e29 into ceph:master Dec 26, 2016

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@badone badone removed the needs-review label Dec 26, 2016

@badone badone deleted the badone:wip-c_read_operations-valgrind-fixes branch Dec 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment