New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/OSDMonitor: fixup sortbitwise flag warning #12682

Merged
merged 1 commit into from Dec 27, 2016

Conversation

Projects
None yet
3 participants
@renhwztetecs
Member

renhwztetecs commented Dec 27, 2016

"ceph -s" does not report warning when using
command "ceph osd unset sortbitwise" to drop
sortbitwise flag.
we should use "osdmap.get_up_osd_features() &
CEPH_FEATURE_OSD_BITWISE_HOBJ_SORT"
instead of "(osdmap.get_features(CEPH_ENTITY_TYPE_OSD, NULL) &
CEPH_FEATURE_OSD_BITWISE_HOBJ_SORT)",
because osdmap.get_features only get local "features"

Signed-off-by: huanwen ren ren.huanwen@zte.com.cn

mon/OSDMonitor: fixup sortbitwise flag warning
"ceph -s" does not report warning when using
command "ceph osd unset sortbitwise" to drop
sortbitwise flag.
we should use "osdmap.get_up_osd_features() &
CEPH_FEATURE_OSD_BITWISE_HOBJ_SORT"
instead of "(osdmap.get_features(CEPH_ENTITY_TYPE_OSD, NULL) &
CEPH_FEATURE_OSD_BITWISE_HOBJ_SORT)",
because osdmap.get_features only get local "features"

Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>

@tchaikov tchaikov self-assigned this Dec 27, 2016

@tchaikov tchaikov added the needs-qa label Dec 27, 2016

@tchaikov tchaikov added this to the kraken milestone Dec 27, 2016

@liewegas liewegas merged commit 3323230 into ceph:master Dec 27, 2016

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@renhwztetecs renhwztetecs deleted the renhwztetecs:renhw-wip-mon-osdmonitor-sortbitwise branch Dec 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment