New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/ops: add sanity checks to run-make-check.sh #12683

Merged
merged 1 commit into from Jan 12, 2017

Conversation

Projects
None yet
2 participants
@smithfarm
Contributor

smithfarm commented Dec 27, 2016

Signed-off-by: Nathan Cutler ncutler@suse.com

build/ops: add sanity checks to run-make-check.sh
Signed-off-by: Nathan Cutler <ncutler@suse.com>

@smithfarm smithfarm added the build/ops label Dec 27, 2016

@badone

badone approved these changes Dec 28, 2016

Looks OK to me

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Jan 12, 2017

Contributor

Testing manually in Xenial docker container without sudo package:

$ bash run-make-check.sh 
Checking hostname sanity... OK
Please install sudo and re-run. This script assumes it is running
as a normal user with the ability to run commands as root via sudo.

(Running as root, same thing happens.)

After installing sudo, but not configuring it:

$ bash run-make-check.sh 
Checking hostname sanity... OK
[sudo] password for smithfarm:

As root:

# bash run-make-check.sh
For best results, run this script as a normal user configured
with the ability to run commands as root via sudo.
Checking hostname sanity... OK
[execution continues]

After configuring sudo, execution proceeds as usual.

Next test - CentOS 7.3

Contributor

smithfarm commented Jan 12, 2017

Testing manually in Xenial docker container without sudo package:

$ bash run-make-check.sh 
Checking hostname sanity... OK
Please install sudo and re-run. This script assumes it is running
as a normal user with the ability to run commands as root via sudo.

(Running as root, same thing happens.)

After installing sudo, but not configuring it:

$ bash run-make-check.sh 
Checking hostname sanity... OK
[sudo] password for smithfarm:

As root:

# bash run-make-check.sh
For best results, run this script as a normal user configured
with the ability to run commands as root via sudo.
Checking hostname sanity... OK
[execution continues]

After configuring sudo, execution proceeds as usual.

Next test - CentOS 7.3

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Jan 12, 2017

Contributor

Tested manually in CentOS 7.2.1511 docker container:

As normal user in minimal environment:

$ bash run-make-check.sh
Checking hostname sanity... OK
Please install bc and re-run.

As root, same behavior.

After installing bc, behavior is the same as for Xenial, above. It complains about sudo, etc.

Contributor

smithfarm commented Jan 12, 2017

Tested manually in CentOS 7.2.1511 docker container:

As normal user in minimal environment:

$ bash run-make-check.sh
Checking hostname sanity... OK
Please install bc and re-run.

As root, same behavior.

After installing bc, behavior is the same as for Xenial, above. It complains about sudo, etc.

@smithfarm smithfarm merged commit 8c724a5 into ceph:master Jan 12, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@smithfarm smithfarm deleted the SUSE:wip-run-make-check-deps branch Jan 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment