New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update test_rados_tool.sh, use POOL and OBJ var #12706

Merged
merged 1 commit into from Jan 2, 2017

Conversation

Projects
None yet
2 participants
@Liuchang0812
Contributor

Liuchang0812 commented Dec 29, 2016

  • replace hard-code pool name with $POOL
  • replace hard-code object name with $OBJ
  • introduce a new variable called $POOL_EC
  • clean up pool
  • simplify test case

ref to #12674
@tchaikov @liewegas

Signed-off-by: liuchang0812 liuchang0812@gmail.com

# clean up environment, delete pool
$CEPH_TOOL osd pool delete $POOL $POOL --yes-i-really-really-mean-it
$CEPH_TOOL osd pool delete $POOL_EC $POOL_EC --yes-i-really-really-mean-it
$CEPH_TOOL osd pool delete $POOL_CP_TARGE $POOL_CP_TARGET --yes-i-really-really-mean-it

This comment has been minimized.

@tchaikov

tchaikov Dec 29, 2016

Contributor

s/POOL_CP_TARGE/POOL_CP_TARGET/

This comment has been minimized.

@Liuchang0812

Liuchang0812 Dec 29, 2016

Contributor

done, thanks.

by the way, it seems that "ceph osd pool delete" will always returns 0 whether it's successfully or not.

This comment has been minimized.

@Liuchang0812

Liuchang0812 Dec 29, 2016

Contributor

ok, i have tried it.
ceph returns 0 if pool isn't exist.
ceph returns 1 if pool1 != pool2 and pool1 exists.

then
die "Append failed expecting $orig_size read $read_size"
fi
$RADOS_TOOL -p $POOL append $OBJ ./rados_append_4k

This comment has been minimized.

@tchaikov

tchaikov Dec 29, 2016

Contributor

this changes the behavior of this test. prior to this change, we

  1. create an empty object
  2. append 4k "0" blob to it
  3. compare it with the 4k blob

after this change

  1. append 4k "0" blob to a non-exisitent object
  2. compare it with the 4k blob

This comment has been minimized.

@Liuchang0812

Liuchang0812 Dec 29, 2016

Contributor

done. very thanks for your review

@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Dec 29, 2016

Test this please

@@ -267,7 +271,7 @@ done
run_expect_nosignal "$RADOS_TOOL" --pool "$POOL" bench 1 rand
run_expect_nosignal "$RADOS_TOOL" --pool "$POOL" bench 1 seq
set -e
set -e

This comment has been minimized.

@tchaikov

tchaikov Dec 29, 2016

Contributor

trailing space.

This comment has been minimized.

@Liuchang0812

Liuchang0812 Dec 29, 2016

Contributor

working on this

This comment has been minimized.

@Liuchang0812

Liuchang0812 Dec 29, 2016

Contributor

done, I have squashed commits. thanks tchaikov

test: update test_rados_tool.sh, use POOL and OBJ var
* replace hard-code pool name with $POOL
* replace hard-code object name with $OBJ
* introduce a new variable called $POOL_EC
* clean up pool
* simplify test case

Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Dec 30, 2016

@tchaikov ping

@tchaikov tchaikov merged commit 8b07aad into ceph:master Jan 2, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov self-assigned this Jan 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment